Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Spin off from #103156
This offers an alternative FHS based packaging for the tor browser. This may be useful for some people (due to faster updates, or perhaps less chance of breakage, due to being closer to upstream), but obviously has its drawbacks. It is not as close to the spirit of Nix / NixOS and will waste disk space, by keeping a separate copy of the (compressed) source in the store, in addition to the one in the local prefix.
Another rationale for writing this may be that mozilla is known for increasingly trying to lock down the browser, thereby sadly making the kind of packaging as required in
nixpkgs
more difficult to do properly.Implementation details
.local/share/tor-browser-mutable/
as prefix (separate from the prefix of tor-browser-bundle-bin), so they should not collide.passthru
attribute of tor-browser-bundle-bin, to keep versions in sync; hope that's a valid thing to do.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)