Skip to content

ocamlPackages.httpaf: 0.4.1 → 0.6.6 #103663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2020
Merged

ocamlPackages.httpaf: 0.4.1 → 0.6.6 #103663

merged 1 commit into from
Nov 20, 2020
+17 −5

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Nov 13, 2020

Motivation for this change

Fixes & improvements: https://github.com/inhabitedtype/httpaf/releases

Use Dune 2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@vbgl vbgl added 8.has: package (update) This PR updates a package to a newer version 6.topic: ocaml labels Nov 13, 2020
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 13, 2020
sternenseemann
sternenseemann approved these changes Nov 14, 2020
View reviewed changes
Copy link
Member

@sternenseemann sternenseemann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, builds fine on x86_64 NixOS.

@vbgl vbgl merged commit c408461 into NixOS:master Nov 20, 2020
@vbgl vbgl deleted the ocaml-httpaf-0.6.6 branch November 20, 2020 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternenseemann sternenseemann

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @sternenseemann