sc-controller: unbreak by restoring pygobject3 for python2 #103650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Nov 13, 2020
Comment on lines
5075
to
+5160
| pygobject2 = callPackage ../development/python-modules/pygobject { inherit (pkgs) pkgconfig; }; | ||
|
|
||
| pygobject3 = callPackage ../development/python-modules/pygobject/3.nix { inherit (pkgs) meson pkgconfig; }; | ||
| pygobject3 = if isPy3k then | ||
| callPackage ../development/python-modules/pygobject/3.nix { inherit (pkgs) meson pkgconfig; } | ||
| else | ||
| callPackage ../development/python-modules/pygobject/3.36.nix { inherit (pkgs) meson pkgconfig; }; |
There was a problem hiding this comment.
not super related to your changes, but default.nix should be the one that can be updated to the latest, the "pinned" versions should be the ones that specify a version number.
rnhmjoj
approved these changes
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Unbreak sc-controller.
Upstream issue re. python3: kozec/sc-controller#498.
pygobject maintainers recommend keeping 3.36 for python2: https://github.com/GNOME/pygobject/blob/3.38.0/NEWS#L7
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)