Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b3sum: 0.3.4 -> 0.3.7 #103654

Merged
merged 1 commit into from Nov 23, 2020
Merged

b3sum: 0.3.4 -> 0.3.7 #103654

merged 1 commit into from Nov 23, 2020

Conversation

ivan
Copy link
Member

@ivan ivan commented Nov 13, 2020

Motivation for this change

https://github.com/BLAKE3-team/BLAKE3/releases

I don't know why I had to move Cargo.lock to the root, but the build didn't work otherwise.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I tested it on NixOS 20.09 and it seemed to work fine.

cc maintainer @fpletz

@ryantm
Copy link
Member

ryantm commented Nov 23, 2020

Result of nixpkgs-review pr 103654 1

1 package built:
  • b3sum

@ryantm ryantm merged commit ee03fb8 into NixOS:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants