Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] brave: 1.15.76 -> 1.17.73 #103658

Merged
merged 3 commits into from Dec 9, 2020
Merged

[20.09] brave: 1.15.76 -> 1.17.73 #103658

merged 3 commits into from Dec 9, 2020

Conversation

JeffLabonte
Copy link
Contributor

@JeffLabonte JeffLabonte commented Nov 13, 2020 •
edited

Backported from: #103268

(cherry picked from commit 13e4f18)
Reason: The browser must be kept up-to-date

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JeffLabonte
brave: 1.15.76 -> 1.16.72
31910dc 
(cherry picked from commit 13e4f18)
Reason: The browser must be kept up-to-date
@ofborg ofborg bot requested review from rht and uskudnik November 13, 2020 05:15
@JeffLabonte JeffLabonte changed the title [20/09] brave: 1.15.76 -> 1.16.72 [20.09] brave: 1.15.76 -> 1.16.72 Nov 16, 2020
@buckley310
Copy link
Contributor

Looks good to me. Tested by building it and browsing a few websites.

1.17 just hit unstable recently. If you feel like bumping this PR to 1.17 I will re-review it. If not, then it's good as-is.

@JeffLabonte
Copy link
Contributor Author

Looks good to me. Tested by building it and browsing a few websites.

1.17 just hit unstable recently. If you feel like bumping this PR to 1.17 I will re-review it. If not, then it's good as-is.

I am planning to update my PR to include 1.17 as well. I will poke you once it is done.

@JeffLabonte
Copy link
Contributor Author

I will wait for another version to come up to fix the CVE.

#106185

@buckley310
Copy link
Contributor

buckley310 commented Dec 7, 2020 •
edited

@JeffLabonte I wouldn't wait on this... 1.16.72 and below has some memory corruption vulnerabilities in it. CVE-2020-8276 is pretty minor in my view. I would bump this to at least 1.16.76 (I would do 1.17) and push it through now.

JeffLabonte and others added 2 commits December 7, 2020 12:08
@JeffLabonte
brave: 1.16.72 -> 1.16.76
fe1a0a6 
(cherry picked from commit 6d730ef)
reason: Keep browser up-to-date for security purposes
@buckley310 @JeffLabonte
brave: 1.16.76 -> 1.17.73
8810627 
(cherry picked from commit 1cd7039)
reason: Keep browser to the latest version
@JeffLabonte JeffLabonte changed the title [20.09] brave: 1.15.76 -> 1.16.72 [20.09] brave: 1.15.76 -> 1.17.73 Dec 7, 2020
@JeffLabonte
Copy link
Contributor Author

@buckley310 Done 😄

@buckley310
Copy link
Contributor

Looks good to me. Checked out the 20.09 branch from a 20.09 system, and cherry-picked these commits.
I tried loading a few various websites and everything works as expected.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/296

@AndersonTorres AndersonTorres merged commit 5cf5afc into NixOS:release-20.09 Dec 9, 2020
@JeffLabonte JeffLabonte deleted the backport/20.09_brave_1.15.76_to_1.16.72 branch December 9, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rht rht Awaiting requested review from rht

@uskudnik uskudnik Awaiting requested review from uskudnik

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JeffLabonte @buckley310 @nixos-discourse @FRidh @AndersonTorres