Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell: Add cabal2nixOptions to developPackage #103660

Merged
merged 1 commit into from Nov 13, 2020
Merged

haskell: Add cabal2nixOptions to developPackage #103660

merged 1 commit into from Nov 13, 2020

Conversation

expipiplus1
Copy link
Contributor

Motivation for this change

Currently it's quite cumbersome to set these options with developPackages (have to override callCabal2xnix)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@expipiplus1
haskell: Add cabal2nixOptions to developPackage
8f23b9a 
Also neaten documentation slightly
expipiplus1 added a commit to expipiplus1/vulkan that referenced this pull request Nov 13, 2020
@expipiplus1
Greatly simplify nix expressions
f3dc810 
Requires NixOS/nixpkgs#103660
cdepillabout
cdepillabout approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! All these changes are really making developPackage easier to use.

@cdepillabout cdepillabout merged commit d3edc3a into NixOS:haskell-updates Nov 13, 2020
@expipiplus1
Copy link
Contributor Author

expipiplus1 commented Nov 13, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@expipiplus1 @cdepillabout