Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-ethereum: 1.9.23 -> 1.9.24 #103653

Merged
merged 1 commit into from Nov 15, 2020
Merged

go-ethereum: 1.9.23 -> 1.9.24 #103653

merged 1 commit into from Nov 15, 2020

Conversation

RaghavSood
Copy link
Member

Motivation for this change

New upstream version

Contains consensus fix, I will backport once this is in master

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@d-xo d-xo mentioned this pull request Nov 13, 2020
10 tasks
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/369

@mmahut mmahut merged commit f4c29b8 into NixOS:master Nov 15, 2020
@paulperegud
Copy link

Works well on Ubuntu 20.04. Build using nix-shell -p nixpkgs-review --run "nixpkgs-review pr 103653"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants