Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gst_all_1.gst-plugins-bad: libva is Linux-only #104098

Merged
merged 1 commit into from Nov 19, 2020
Merged

gst_all_1.gst-plugins-bad: libva is Linux-only #104098

merged 1 commit into from Nov 19, 2020

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Nov 17, 2020 •
edited

Motivation for this change

Fixes #104062 (build on Darwin).

This will be a mass-rebuild because buildInputs was reordered, but I want to switch to staging only after ofborg or somebody else confirms the build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nh2
Copy link
Contributor Author

nh2 commented Nov 17, 2020

@GrahamcOfBorg build gst_all_1.gst-plugins-bad

@nh2 nh2 mentioned this pull request Nov 17, 2020
Closed
@nh2
Copy link
Contributor Author

nh2 commented Nov 17, 2020 •
edited

@SuperSandro2000 Can you also try to build this for me on Darwin, like the other package?

@ofborg ofborg bot requested a review from matthewbauer November 17, 2020 22:39
@lukegb
Copy link
Contributor

lukegb commented Nov 18, 2020 •
edited

Result of nixpkgs-review pr 104098 1

1 package failed to build:
  • gst_all_1.gst-plugins-bad
$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /Users/lukegb/.cache/nixpkgs-review/pr-104098-1/build.nix
builder for '/nix/store/fx227z5wb9g15xz15d6gb5mp3n3va2ga-gst-plugins-bad-1.18.0.drv' failed with exit code 1; last 10 log lines:
  Library lumin_rt_app_1_5 skipped: feature magicleap disabled
  Has header "sys/socket.h" : YES (cached)
  Dependency gudev-1.0 skipped: feature uvch264 disabled
  Dependency libusb-1.0 skipped: feature uvch264 disabled
  Has header "linux/uvcvideo.h" : NO 
  Run-time dependency gudev-1.0 found: NO (tried pkgconfig and framework)
  
  sys/v4l2codecs/meson.build:12:0: ERROR: Dependency "gudev-1.0" not found, tried pkgconfig and framework
  
  A full log can be found at /private/tmp/nix-build-gst-plugins-bad-1.18.0.drv-0/gst-plugins-bad-1.18.0/build/meson-logs/meson-log.txt
cannot build derivation '/nix/store/p19kifpb0dm9i6bwql08k1vnjpxhdlnf-env.drv': 1 dependencies couldn't be built

@lukegb
Copy link
Contributor

lukegb commented Nov 18, 2020

Adding

    "-Dv4l2codecs=disabled"

to the pile-o-switches made it compile for me.

@nh2 nh2 force-pushed the issues-104062-gstreamer-libva-linux-only branch from f715197 to 691e6e4 Compare November 18, 2020 20:14
@nh2
Copy link
Contributor Author

nh2 commented Nov 18, 2020

@GrahamcOfBorg build

@nh2
Copy link
Contributor Author

nh2 commented Nov 18, 2020

@lukegb @kfiz OK, I pushed what you found

@lukegb
Copy link
Contributor

lukegb commented Nov 18, 2020

Probably makes sense to pull this into staging at the same time as #103849

@lukegb
Copy link
Contributor

lukegb commented Nov 18, 2020 •
edited

Result of nixpkgs-review pr 104098 1

1 package built:
  • gst_all_1.gst-plugins-bad

LGTM! 👍

@nh2
Copy link
Contributor Author

nh2 commented Nov 19, 2020 •
edited

Probably makes sense to pull this into staging at the same time as #103849

Actually, I think we should merge this PR against master. The rebuild here turned out much smaller than expected (~300 packages), while the other PR rebuilds 4x more.

This is mostly beacause this only touches -plugins-bad, not all of gstreamer.

@nh2 nh2 merged commit 7c8451d into NixOS:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gst-plugins-bad-1.18.0 does not build on Darwin
2 participants
@nh2 @lukegb