Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Electron 11, updates for Electron 8 and 9 #104057

Merged
merged 4 commits into from Nov 20, 2020
Merged

Introduce Electron 11, updates for Electron 8 and 9 #104057

merged 4 commits into from Nov 20, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Nov 17, 2020 •
edited

Motivation for this change

Introduce Electron 11
Updates for Electron 8, 9 and 10

https://www.electronjs.org/releases/stable?version=8
https://www.electronjs.org/releases/stable?version=9
https://www.electronjs.org/releases/stable?version=10
https://www.electronjs.org/releases/stable?version=11

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak force-pushed the electron branch 2 times, most recently from 0364a00 to 31daed4 Compare November 19, 2020 10:06
@gebner gebner merged commit 660b92c into NixOS:master Nov 20, 2020
@gebner
Copy link
Member

gebner commented Nov 20, 2020

Backported as 37ad3b2 and 9ca98ac and ef2031c.

@prusnak prusnak deleted the electron branch November 21, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manveru manveru Awaiting requested review from manveru

@travisbhartwell travisbhartwell Awaiting requested review from travisbhartwell

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prusnak @gebner