Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libmicrodns: Change platforms to unix #104071

Merged
merged 1 commit into from Nov 17, 2020
Merged

libmicrodns: Change platforms to unix #104071

merged 1 commit into from Nov 17, 2020

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Nov 17, 2020 •
edited

Motivation for this change

Hopefully fixes not enough yet #104062 (gstreamer build on Darwin), will test with ofborg.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nh2
Copy link
Contributor Author

nh2 commented Nov 17, 2020

@GrahamcOfBorg build

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104071 run on x86_64-darwin 1

1 package built:
  • libmicrodns

@nh2
Copy link
Contributor Author

nh2 commented Nov 17, 2020

@GrahamcOfBorg build gst_all_1.gst-plugins-bad

@nh2 nh2 force-pushed the issues-104062-libmicrodns-unix branch from a9b9849 to 2a0fbf0 Compare November 17, 2020 21:34
@nh2 nh2 merged commit c05e9d9 into NixOS:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nh2 @SuperSandro2000