Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getmail6: init at 6.9 #104054

Merged
merged 1 commit into from Jan 25, 2021
Merged

getmail6: init at 6.9 #104054

merged 1 commit into from Jan 25, 2021

Conversation

wahjava
Copy link
Contributor

@wahjava wahjava commented Nov 17, 2020 •
edited

Motivation for this change

Add a derivation for getmail6 (fork of getmail, adapted to work with Python3).

It's mostly based on existing getmail derivation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104054 run on x86_64-darwin 1

1 package built:
  • getmail6

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104054 run on x86_64-linux 1

1 package built:
  • getmail6

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104054 run on x86_64-linux 1

1 package built:
  • getmail6

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 104054 run on x86_64-darwin 1

1 package built:
  • getmail6

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

getmail6:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 104054 run on x86_64-linux 1

1 package built:
  • getmail6

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

getmail6:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

@wahjava
Copy link
Contributor Author

wahjava commented Jan 23, 2021

While here, I also updated to 6.14.

If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

Since this is not a library, I believe I don't need to any pythonImportsCheck. Could you confirm, if I am understanding it correctly ?

Thanks!

@SuperSandro2000
Copy link
Member

Since this is not a library, I believe I don't need to any pythonImportsCheck. Could you confirm, if I am understanding it correctly ?

If the package is importable please add it. If it is not then you can skip it.

@wahjava
Copy link
Contributor Author

wahjava commented Jan 23, 2021

Since this is not a library, I believe I don't need to any pythonImportsCheck. Could you confirm, if I am understanding it correctly ?

If the package is importable please add it. If it is not then you can skip it.

There is an importable package in it, so I have added a pythonImportsCheck.

Thanks!

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 104054 run on x86_64-darwin 1

1 package built:
  • getmail6

@SuperSandro2000 SuperSandro2000 merged commit ed5be9f into NixOS:master Jan 25, 2021
@wahjava wahjava deleted the getmail6 branch January 25, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wahjava @SuperSandro2000