Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicity: add missing deps for S3 #104089

Merged
merged 1 commit into from Jan 4, 2021
Merged

Conversation

enolan
Copy link
Contributor

@enolan enolan commented Nov 17, 2020

Motivation for this change

At some point Duplicity added support for the boto3 library, but we didn't add the dependency on the library so it's broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • It adds ~52 megs, which is kind of ridiculous. I still think this is better than having the man page tell you to do something that just gives you an inscrutable error message.
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vikanezrimaya
Copy link
Member

There's boto and boto3 in this list, which sounds suspicious.

@enolan
Copy link
Contributor Author

enolan commented Nov 21, 2020 via email

@paraseba
Copy link
Contributor

paraseba commented Jan 4, 2021

Is there anything blocking this? How can I help? I have being running with boto3 for a long time without any issues, but tests take so long to run, having duplicity+boto3 cached would be great.

@enolan
Copy link
Contributor Author

enolan commented Jan 4, 2021 via email

@peti peti merged commit 4a55ebe into NixOS:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants