Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tor: 0.4.4.5 -> 0.4.4.6 #104076

Merged
merged 1 commit into from Nov 20, 2020
Merged

tor: 0.4.4.5 -> 0.4.4.6 #104076

merged 1 commit into from Nov 20, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Nov 17, 2020 •
edited

Motivation for this change
  • Version update
  • Add me to maintainers
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member

Added the security label. Fixes TROVE-2020-005. (https://trac.torproject.org/projects/tor/wiki/TROVE)

  o Major bugfixes (security, backport from 0.4.5.1-alpha):
    - When completing a channel, relays now check more thoroughly to
      make sure that it matches any pending circuits before attaching
      those circuits. Previously, address correctness and Ed25519
      identities were not checked in this case, but only when extending
      circuits on an existing channel. Fixes bug 40080; bugfix on
      0.2.7.2-alpha. Resolves TROVE-2020-005.

Daemon starts up, bootstraps the connection as soon as I try to use the proxy socket, LGTM.

@mweinelt
Copy link
Member

I think it is prudent to also update 20.09 to the 0.4.4 series, as 0.4.3 will be EOL before 20.09 goes out of support.

@mweinelt mweinelt added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 20, 2020
mweinelt
mweinelt approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for stepping up. LGTM.

@mweinelt mweinelt merged commit 661981e into NixOS:master Nov 20, 2020
@mweinelt
Copy link
Member

Oh and maybe we could reference https://trac.torproject.org/projects/tor/wiki/org/teams/NetworkTeam/CoreTorReleases#Listofreleases somewhere in the the package.

@prusnak prusnak deleted the tor branch November 20, 2020 07:43
@prusnak
Copy link
Member Author

prusnak commented Nov 20, 2020

Port to stable in #104365

@mweinelt mweinelt removed the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@Phreedom Phreedom Awaiting requested review from Phreedom

@joachifm joachifm Awaiting requested review from joachifm

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prusnak @mweinelt