Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mm: 2016.11.04 -> 2020.11.17 #104055

Merged
merged 2 commits into from Nov 23, 2020
Merged

mm: 2016.11.04 -> 2020.11.17 #104055

merged 2 commits into from Nov 23, 2020

Conversation

ghost
Copy link

@ghost ghost commented Nov 17, 2020

Motivation for this change

Repository was moved and package would fail to build.

Things done

Updated the repository, changed to a go module.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit November 17, 2020 14:59
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104055 run on x86_64-darwin 1

1 package built:
  • mm

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104055 run on x86_64-linux 1

1 package built:
  • mm

@SuperSandro2000 SuperSandro2000 merged commit 6a4d317 into NixOS:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperSandro2000 @meutraa