Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more gnome updates #104074

Merged
merged 16 commits into from Nov 18, 2020
Merged

more gnome updates #104074

merged 16 commits into from Nov 18, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Nov 17, 2020

Motivation for this change

cc @NixOS/gnome

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • gnome-souund-output-device chooser seems to activate without any journal errors
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

It does not work with recent glade.
@worldofpeace worldofpeace added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label Nov 18, 2020
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed all the changelogs and everything looked fine. I didn't catch any change in a changelog that needed to represent a change in the nix expression. Haven't built anything. I would say merge but there is issues in gnome-calendar that I've noticed that fedora is patching in https://src.fedoraproject.org/rpms/gnome-calendar/c/bc4fe967c1db2e6ae13c520695b02995ef500a04?branch=master etc. (tbh we could pull a patch diff from the release to master 😁 ), and I believe we talked about reverting the mimetypes change in totem.

@jtojnar jtojnar added this to In Progress in GNOME 3.38 Nov 18, 2020
@jtojnar
Copy link
Contributor Author

jtojnar commented Nov 18, 2020

Will merge this now to avoid further ofborg spam. Added the issues to 3.38 project.

@jtojnar jtojnar merged commit 9635686 into NixOS:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: documentation 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants