vim_configurable: restore python derivation overriding #104077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current Vim, the Python support can be implemented by linking to the Python library, e.g., lib/libpython3.8.dylib on darwin. The previous workaround of wrapping Vim to prefix $PATH is not sufficient anymore. Since in the current Vim, the Python interpreter is no longer invoked, but instead, the dynamically linked library is used, in which only the original Python modules are loaded, causing plugins to fail to load their required Python modules. Experiments show that, however, it is controlled by the $NIX_PYTHONPATH environment variable. In this commit, we add the required environment variable to the wrapped Vim workaround as previously proposed. So that the Vim plugins can use Python modules in the specified Python derivation.
|
@SuperSandro2000 Merge conflict resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
In the current Vim, the Python support can be implemented by linking to the Python library, e.g.,
lib/libpython3.8.dylibon darwin. The previous workaround of wrapping Vim to prefix$PATHis not sufficient anymore. Since in the current Vim, the Python interpreter is no longer invoked, but instead, the dynamically linked library is used, in which only the original Python modules are loaded, causing plugins to fail to load their required Python modules.Experiments show that, however, it is controlled by the
$NIX_PYTHONPATHenvironment variable, as in development/interpreters/python/wrapper.nix. In this commit, we add the required environment variable to the wrapped Vim workaround as previously proposed. So that the Vim plugins can use Python modules in the specified Python derivation.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)