Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aliases: rfkill is replaced by utillinux, not util-linux #104078

Merged
merged 1 commit into from Nov 17, 2020
Merged

aliases: rfkill is replaced by utillinux, not util-linux #104078

merged 1 commit into from Nov 17, 2020

Conversation

makefu
Copy link
Contributor

@makefu makefu commented Nov 17, 2020

Motivation for this change

Stumbled upon the warning for rfkill, however the replacement package is called utillinux (at least in nixpkgs) and not util-inux

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 merged commit 2f3ffe7 into NixOS:master Nov 17, 2020
@makefu makefu deleted the docs/aliases/rfkill branch November 17, 2020 19:16
@makefu makefu mentioned this pull request Nov 17, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@makefu @Mic92