New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maintainers: create sage team #104083
maintainers: create sage team #104083
Conversation
@7c6f434c do you want to be a member of that team? |
99c440e
to
c359995
Compare
For some reason my local eval check is failing, but I don't see what is wrong. Other teams are used in the same way. Checking if ofBorg also gives an error. |
@7c6f434c do you want to be a member of that team?
Right now I will not be a good one… I have forgotten all the Sage stuff from my failures, and I am usually a bit behind on reacting to things…
But could join with a hope of providing a fallback when fixing some of the dependencies.
|
Maintaining all the packages whose updates might break some aspect of sage. For reference: NixOS#103810 (comment)
c359995
to
ff83383
Compare
More eyes are always better. I'll probably also take on more of an advisory role, at least for the near future. The biggest risk I see with teams is dilution of responsibility, but it should be manageable. Does b7319d2 look good do you @7c6f434c? @omasanori please also explicitly approve the PR if you are fine with it. I don't want to add anybody against their will ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timokau Sorry for my late response.
I am glad to join the team to help the sustainability of nixpkgs mathematical and scientific computing stack.
@timokau I am definitely OK with not being maintainer on those things. I am also OK as being listed in the team; I guess for now it has the benefit of me automatically being notified of changes approved by @omasanori so I can merge them (I read what I merge, but I always trust other people's claim of testing, and mostly trust some people's claims of impact evaluation). If both of us have spotty availability I guess it's better to flip the coin twice? |
I'd say that was quite fast :)
Similar for me.
Alright, let's go ahead with this then! |
I think you ended up not adding me, at least judging from GitHub diff; I am fine with it if it was your intent; otherwise I guess I wonder if it is mixing up what you committed and what you did not, or GitHub failing at diffs, because the latter case would be… something to know, but no longer unimaginable |
Right, I didn't stage my changes to |
Motivation for this change
Maintaining all the packages whose updates might break some aspect of
sage.
For reference:
#103810 (comment)
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)