Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintainers: create sage team #104083

Merged
merged 2 commits into from Nov 19, 2020
Merged

Conversation

timokau
Copy link
Member

@timokau timokau commented Nov 17, 2020

Motivation for this change

Maintaining all the packages whose updates might break some aspect of
sage.

For reference:
#103810 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member Author

timokau commented Nov 17, 2020

@7c6f434c do you want to be a member of that team?

@timokau
Copy link
Member Author

timokau commented Nov 17, 2020

For some reason my local eval check is failing, but I don't see what is wrong. Other teams are used in the same way. Checking if ofBorg also gives an error.

@7c6f434c
Copy link
Member

7c6f434c commented Nov 17, 2020 via email

Maintaining all the packages whose updates might break some aspect of
sage.

For reference:
NixOS#103810 (comment)
@timokau
Copy link
Member Author

timokau commented Nov 18, 2020

But could join with a hope of providing a fallback when fixing some of the dependencies.

More eyes are always better. I'll probably also take on more of an advisory role, at least for the near future. The biggest risk I see with teams is dilution of responsibility, but it should be manageable.

Does b7319d2 look good do you @7c6f434c?

@omasanori please also explicitly approve the PR if you are fine with it. I don't want to add anybody against their will ;)

Copy link
Contributor

@omasanori omasanori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timokau Sorry for my late response.

I am glad to join the team to help the sustainability of nixpkgs mathematical and scientific computing stack.

@7c6f434c
Copy link
Member

@timokau I am definitely OK with not being maintainer on those things. I am also OK as being listed in the team; I guess for now it has the benefit of me automatically being notified of changes approved by @omasanori so I can merge them (I read what I merge, but I always trust other people's claim of testing, and mostly trust some people's claims of impact evaluation). If both of us have spotty availability I guess it's better to flip the coin twice?

@timokau
Copy link
Member Author

timokau commented Nov 19, 2020

Sorry for my late response.

I'd say that was quite fast :)

I read what I merge, but I always trust other people's claim of testing, and mostly trust some people's claims of impact evaluation.

Similar for me.

I am also OK as being listed in the team

Alright, let's go ahead with this then!

@timokau timokau merged commit e04721b into NixOS:master Nov 19, 2020
@timokau timokau deleted the sage-maintainers-team branch November 19, 2020 18:20
@7c6f434c
Copy link
Member

I think you ended up not adding me, at least judging from GitHub diff; I am fine with it if it was your intent; otherwise I guess I wonder if it is mixing up what you committed and what you did not, or GitHub failing at diffs, because the latter case would be… something to know, but no longer unimaginable

@timokau
Copy link
Member Author

timokau commented Nov 21, 2020

Right, I didn't stage my changes to team-list.nix when making the second commit! Thanks for noticing, I'll fix that up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants