Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aacgain: fix src #104058

Merged
merged 1 commit into from Nov 17, 2020
Merged

aacgain: fix src #104058

merged 1 commit into from Nov 17, 2020

Conversation

RaghavSood
Copy link
Member

Motivation for this change

#104048

The project moved to gitlab

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124 ajs124 merged commit bbd083c into NixOS:master Nov 17, 2020
prusnak
prusnak reviewed Nov 17, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but left two optional suggestions

pkgs/applications/audio/aacgain/default.nix
Comment on lines 3 to 4
stdenv.mkDerivation {
name = "aacgain-1.9.0";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stdenv.mkDerivation {
name = "aacgain-1.9.0";
stdenv.mkDerivation rec {
pname = "aacgain";
version = "1.9.0";

pkgs/applications/audio/aacgain/default.nix

stdenv.mkDerivation {
name = "aacgain-1.9.0";

src = fetchFromGitHub {
src = fetchFromGitLab {
owner = "mulx";
repo = "aacgain";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repo = "aacgain";
repo = pname;

@RaghavSood
Copy link
Member Author

@prusnak Agreed on the suggestions, but I believe they are already being discussed in #104045 - wanted to scope this PR to solve the major issue on hand

@RaghavSood RaghavSood deleted the aacgain/src branch November 17, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak left review comments

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RaghavSood @ryantm @prusnak @ajs124