Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.numpy: fix tests for >64 core machines #104061

Merged
merged 2 commits into from Nov 17, 2020
Merged

python3Packages.numpy: fix tests for >64 core machines #104061

merged 2 commits into from Nov 17, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 17, 2020 •
edited

Motivation for this change

I couldn't build numpy because the tests kept segfaulting from openblas. Current workaround is to set OMP_NUM_THREADS to limit the number of threads it uses at runtime.

supercedes: #103379
relevant: OpenMathLib/OpenBLAS#2982
relevant: OpenMathLib/OpenBLAS#2993

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer mentioned this pull request Nov 17, 2020
Closed
10 tasks
@jonringer
Copy link
Contributor Author

going to merge when ofborg is done with eval. Was able to build 1500+ packages

[64/1485/5720 built (12 failed), 653 copied (7603.3/7605.8 MiB), 3205.3 MiB DL]

@jonringer jonringer merged commit e949d75 into NixOS:staging Nov 17, 2020
@jonringer jonringer deleted the fix-numpy-threads branch November 17, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer