python37Packages.itemadapter: 0.1.1 -> 0.2.0 #103324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
approved these changes
Nov 10, 2020
There was a problem hiding this comment.
LGTM
Result of nixpkgs-review pr 103324 1
12 packages built:
- python37Packages.itemadapter
- python37Packages.itemloaders
- python37Packages.scrapy
- python37Packages.scrapy-deltafetch
- python37Packages.scrapy-fake-useragent
- python37Packages.scrapy-splash
- python38Packages.itemadapter
- python38Packages.itemloaders
- python38Packages.scrapy
- python38Packages.scrapy-deltafetch
- python38Packages.scrapy-fake-useragent
- python38Packages.scrapy-splash
jonringer
approved these changes
Nov 10, 2020
There was a problem hiding this comment.
LGTM
Result of nixpkgs-review pr 103324 1
12 packages built:
- python37Packages.itemadapter
- python37Packages.itemloaders
- python37Packages.scrapy
- python37Packages.scrapy-deltafetch
- python37Packages.scrapy-fake-useragent
- python37Packages.scrapy-splash
- python38Packages.itemadapter
- python38Packages.itemloaders
- python38Packages.scrapy
- python38Packages.scrapy-deltafetch
- python38Packages.scrapy-fake-useragent
- python38Packages.scrapy-splash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python37Packages.itemadapter is: "Common interface for data container classes"
meta.homepage for python37Packages.itemadapter is: "https://github.com/scrapy/itemadapter"
meta.changelog for python37Packages.itemadapter is: ""
Updates performed
To inspect upstream changes
Impact
Checks done (click to expand)
built on NixOS
Warning: a test defined in
passthru.testsdid not pass0 of 0 passed binary check by having a zero exit code.
0 of 0 passed binary check by having the new version present in output.
found 0.2.0 with grep in /nix/store/3liisqp1g9pzjincngj2c1v83ajc3jya-python3.7-itemadapter-0.2.0
directory tree listing: https://gist.github.com/9219947556a529b24babc4e5f366503b
du listing: https://gist.github.com/b41c9e0017ac412edba5a2e2f35ba48e
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-userslist or you can usesudosince root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-review112 packages built:
Maintainer pings
cc @marsam for testing.