Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: 86.0.4240.183 -> 86.0.4240.193 #103294

Merged
merged 1 commit into from Nov 11, 2020
Merged

chromium: 86.0.4240.183 -> 86.0.4240.193 #103294

merged 1 commit into from Nov 11, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Nov 10, 2020

https://chromereleases.googleblog.com/2020/11/stable-channel-update-for-desktop_9.html

This update includes 1 security fix (no CVE).

Motivation for this change

cc @danielfullmer @thefloweringash

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thefloweringash
Copy link
Member

There seems to be a failing dependency (doxygen) for aarch64. I’ll look into it tomorrow, but we shouldn’t let that hold up this security fix.

@danielfullmer
Copy link
Contributor

Build and briefly tested on x86_64-linux.

@primeos primeos merged commit ae3fdeb into NixOS:master Nov 11, 2020
@primeos primeos mentioned this pull request Nov 11, 2020
Merged
10 tasks
@primeos
Copy link
Member Author

primeos commented Nov 11, 2020

Backported to 20.03 in abe53c3 (forgot to reference this PR :o).

@primeos primeos added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 12, 2020
primeos added a commit to primeos/nixpkgs that referenced this pull request Nov 13, 2020
@primeos
chromium: 86.0.4240.183 -> 86.0.4240.193
3af6255 
https://chromereleases.googleblog.com/2020/11/stable-channel-update-for-desktop_9.html

This update includes 1 security fix (no CVE).

(cherry picked from commit 841664a)
Backport of NixOS#103294.
@erictapen
Copy link
Member

Was packported in 3af6255.

@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 14, 2021
@primeos
Copy link
Member Author

primeos commented Jan 14, 2021

@erictapen thanks! Guess this means I should remove the "9.needs: port to stable" in the future, right? (I thought it wouldn't matter if the PR's closed but in hindsight it seems like a good idea to remove the label so that it is clear that the update got backported.)
Or tbh I'll probably just stop using the label for future Chromium updates (or assign "8.has: port to stable" right away so that I don't have to remember to update it) as security updates need to be backported anyway. Would be nice if we had a bot for backports... :)

@erictapen
Copy link
Member

Mh yeah I think it'd make sense to use 9.needs: port to stable and 8.has: port to stable as a method to communicate the state of a PR regarding its backports. They way I read them is that you only should add has port to stable if the commits actually landed in staging-20.09 or release-20.09. This way we can easily detect if a backport was forgotten.

But I'm actually not absolutely sure how it is commonly understood. I opened #109263 to document the semantics as I think would make sense.

👍 for better backport automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@primeos @thefloweringash @danielfullmer @erictapen