Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.haskell-language-server: Fix build #103359

Merged
merged 1 commit into from Nov 11, 2020
Merged

haskellPackages.haskell-language-server: Fix build #103359

merged 1 commit into from Nov 11, 2020

Conversation

maralorn
Copy link
Member

In preparation of the upcoming 0.6.0 release I wanted to fix hls.

It introduces two new plugin packages, which are not on hackage yet.

I remove apply-refact overrides, because current apply-refact versions
are compatible with all ghcs we support, according to their changelog.

I override more of the hls dependencies globally on the whole package
set, to avoid a lot of duplicate compilations. And because @peti changed
my mind about this being a good practice.

hls now uses a released version of ghcide

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@maralorn
haskellPackages.haskell-language-server: Fix build
9bc60f6 
In preparation of the upcoming 0.6.0 release I wanted to fix hls.

It introduces two new plugin packages, which are not on hackage yet.

I remove apply-refact overrides, because current apply-refact versions
are compatible with all ghcs we support, according to their changelog.

I override more of the hls dependencies globally on the whole package
set, to avoid a lot of duplicate compilations. And because @peti changed
my mind about this being a good practice.

hls now uses a released version of ghcide
@maralorn
Copy link
Member Author

@GrahamcOfBorg build haskell-language-server
@GrahamcOfBorg build haskellPackages.ghcide
@GrahamcOfBorg build haskellPackages.brittany

@maralorn
Copy link
Member Author

@ofborg eval

cdepillabout
cdepillabout approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty reasonable.

@maralorn
Copy link
Member Author

Okay, then I'll merge now and monitor hydra closely until friday, to see if it had any unintended side-effects.

@maralorn maralorn merged commit 1204b2e into NixOS:haskell-updates Nov 11, 2020
@maralorn maralorn deleted the bump-hls branch November 11, 2020 09:52
@maralorn
Copy link
Member Author

Everything builds fine. We now have hls 0.6.0 which was released a few hours ago. Can‘t wait to have it in unstable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

Assignees
No one assigned
Labels
6.topic: haskell 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maralorn @cdepillabout