Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tree-wide: unify Bash completions outputs #103315

Merged
merged 0 commits into from Nov 11, 2020
Merged

tree-wide: unify Bash completions outputs #103315

merged 0 commits into from Nov 11, 2020

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Nov 10, 2020 •
edited

Use $out/share/bash-completion/completions to store Bash completions

Motivation for this change

Unify the outputs. Some derivations were outputting the completions in $out/etc/bash_completion.d for example.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

--- Packages building ---

  • gammu
  • prevo-tools
  • todo-txt-cli
  • gitAndTools.git-bug
  • gitAndTools.git-stree
  • gitAndTools.git
  • gitAndTools.top-git
  • purescript
  • backblaze-b2
  • ceph-client - was already broken
  • trace-cmd
  • awscli
  • awscli2
  • google-cloud-sdk
  • tarsnap
  • btrfs-progs
  • yandex-disk
  • gibo
  • powerline-rs
  • pass.extensions.pass-import
  • pass.extensions.pass-update
  • awsebcli
  • nixos-container
  • perlPackages.AppClusterSSH

@zimbatm
Copy link
Member Author

zimbatm commented Nov 11, 2020

Once this has been merged, I will use nix-locate to find the reminding ones. And then finally add a postInstall check so that the convention gets enforced.

@zimbatm zimbatm closed this Nov 11, 2020
@marsam marsam merged commit 3e7fae8 into NixOS:master Nov 11, 2020
@zimbatm
Copy link
Member Author

zimbatm commented Nov 11, 2020

Replaced by #103421 that targets staging.

@flokli
Copy link
Contributor

flokli commented Nov 11, 2020

I don't understand #103315 (comment) - did this mean it was merged to master or not?

@marsam
Copy link
Contributor

marsam commented Nov 11, 2020

I didn't merge it, I guess the github ui is buggy.

@zimbatm
Copy link
Member Author

zimbatm commented Nov 12, 2020 •
edited

I think it's a UI bug as well. It happened when I pushed the merge-base between staging and master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

@flokli flokli Awaiting requested review from flokli

@justinwoo justinwoo Awaiting requested review from justinwoo

@stigtsp stigtsp Awaiting requested review from stigtsp

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zimbatm @flokli @marsam