Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openshot-qt: enable on darwin #103339

Merged
merged 3 commits into from Nov 17, 2020
Merged

openshot-qt: enable on darwin #103339

merged 3 commits into from Nov 17, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Nov 10, 2020 •
edited

Motivation for this change

Provide OpenShot on darwin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 10, 2020
@veprbl veprbl force-pushed the pr/openshot_darwin branch 2 times, most recently from c8ff7ae to 244becd Compare November 10, 2020 20:15
@ofborg ofborg bot requested a review from AndersonTorres November 10, 2020 20:29
@veprbl veprbl force-pushed the pr/openshot_darwin branch 2 times, most recently from e4aabaa to b82fa05 Compare November 11, 2020 01:44
@AndersonTorres AndersonTorres merged commit e8e3f7d into NixOS:master Nov 17, 2020
@veprbl veprbl deleted the pr/openshot_darwin branch November 17, 2020 01:49
@veprbl veprbl restored the pr/openshot_darwin branch December 1, 2020 16:49
@veprbl veprbl deleted the pr/openshot_darwin branch December 1, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @AndersonTorres @SuperSandro2000