Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terragrunt: 0.25.5 -> 0.26.2 #103308

Merged
merged 1 commit into from Nov 12, 2020
Merged

terragrunt: 0.25.5 -> 0.26.2 #103308

merged 1 commit into from Nov 12, 2020

Conversation

06kellyjac
Copy link
Member

@06kellyjac 06kellyjac commented Nov 10, 2020 •
edited

Motivation for this change

Bump terragrunt to 0.26.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (x86_64)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@06kellyjac
Copy link
Member Author

Result of nixpkgs-review pr 103308 1

1 package built:
  • terragrunt

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/364

@ofborg ofborg bot requested review from kalbasit and peterhoeg November 10, 2020 14:20
dbirks
dbirks approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@dbirks dbirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs nicely for me too on NixOS 👍

@06kellyjac
Copy link
Member Author

Thanks for the review @dbirks
If you're interested you can post to this Discourse thread of already reviewed PRs https://discourse.nixos.org/t/prs-already-reviewed/2617 (format is merge: <LINK>)
Not sure what the protocol is with posting something that someone else has reviewed but I can post it in your stead if you'd prefer.

@Lassulus Lassulus merged commit 4edbe7c into NixOS:master Nov 12, 2020
@06kellyjac 06kellyjac deleted the terragrunt_0.26.2 branch November 12, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbirks dbirks dbirks approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@06kellyjac @nixos-discourse @dbirks @Lassulus