Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging] python39Packages: recurseintoAttrs for package set #103360

Merged
merged 4 commits into from Nov 21, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 10, 2020

Motivation for this change

Allow for hydra to build the package set, should be done before 21.03

closes: #100382

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer added this to the 21.03 milestone Nov 10, 2020
@jonringer jonringer changed the title python39Packages: recurseintoAttrs for package set [staging] python39Packages: recurseintoAttrs for package set Nov 10, 2020
@jonringer
Copy link
Contributor Author

ofborg completes locally now:

[17:54:09] jon@nixos ~/projects/nixpkgs (python39)
$ GC_INITIAL_HEAP_SIZE=16g nix-env -f ./outpaths.nix -qaP --no-name --out-path --arg checkMeta true --show-trace > out-paths
[18:01:15] jon@nixos ~/projects/nixpkgs (python39)

Sensitive to exact parser output
@jonringer
Copy link
Contributor Author

cc @FRidh I'm in no hurry to get this merged, but it is ready to merge when we decide to go forward with this.

@rmcgibbo
Copy link
Contributor

FYI: Here were some changes I needed to make via overlays to get the packages I use to build with python39.

let
  unstableTarball = fetchTarball
    "https://github.com/NixOS/nixpkgs/archive/204f52ce65513c0448a283959902fb166adc39f5.tar.gz";
  pkgs = import <nixpkgs> { };
  unstable = import unstableTarball {
    overlays = [
      (self: super: {
        pythonOverrides = python-self: python-super: {

          # Boto doesn't work with python3.9
          boto = python-super.boto3;
          moto = python-super.moto.overrideAttrs( x: {
            # Don't make moto require boto, since boto doesn't work with python3.9
            prePatch = ''
                substituteInPlace setup.py --replace "boto>=2.36.0" ""
            '';
          });
          # pull pyflakes from master
          pyflakes = python-super.pyflakes.overrideAttrs (x: {
            src = super.fetchFromGitHub {
              owner = "PyCQA";
              repo = "pyflakes";
              rev = "26cf0631fe89f61d5b0ef8d6949676f051e35796";
              sha256 = "sha256-F/dQpM7j/MOHOpteUten2ttK78lvwMMmNVOpAFo2gPk=";
            };
          });
        };
        python39 =
          super.python39.override { packageOverrides = self.pythonOverrides; };
      })
    ];
  };
...

@FRidh FRidh merged commit 3eb6d01 into NixOS:staging Nov 21, 2020
@jonringer jonringer deleted the python39 branch February 13, 2022 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants