Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libe57format: Fix dependents not finding its cmake config #103334

Merged
merged 1 commit into from Nov 10, 2020
Merged

libe57format: Fix dependents not finding its cmake config #103334

merged 1 commit into from Nov 10, 2020

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Nov 10, 2020

Motivation for this change

Packages that depended on libe57format cannot find it via cmake without this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nh2 nh2 requested a review from chpatrick November 10, 2020 19:29
@nh2 nh2 self-assigned this Nov 10, 2020
@nh2
Copy link
Contributor Author

nh2 commented Nov 10, 2020

nixpkgs-review results:

3 packages built:
cloudcompare libe57format pdal

@nh2 nh2 merged commit cdbc633 into NixOS:master Nov 10, 2020
@nh2 nh2 mentioned this pull request Nov 10, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chpatrick chpatrick Awaiting requested review from chpatrick

Assignees

@nh2 nh2

Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@nh2