Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/modules/services/x11/clight: update configuration format to new version #103333

Closed
wants to merge 1 commit into from
Closed

nixos/modules/services/x11/clight: update configuration format to new version #103333

wants to merge 1 commit into from

Conversation

dmanam
Copy link
Contributor

@dmanam dmanam commented Nov 10, 2020 •
edited

The new version of clight (which is already in nixpkgs) has a changed configuration file format. This patch just updates the module to use the new format.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@plabadens plabadens requested a review from eadwu April 13, 2021 14:04
@plabadens
Copy link
Contributor

I'm not sure this is relevant anymore, it seems #99314 has fixed the config file generation already, and this module seems to be working fine for me. As far as I can see the generated file has the same format as the example file here: https://github.com/FedeDP/Clight/blob/master/Extra/clight.conf

@dmanam
Copy link
Contributor Author

dmanam commented Apr 16, 2021

Ah, I didn't notice that someone had already made a PR for it.

@dmanam dmanam closed this Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eadwu eadwu Awaiting requested review from eadwu

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dmanam @plabadens