Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aarch64-linux support to resilio-sync pkgs #103357

Merged
merged 1 commit into from Nov 25, 2020
Merged

Add aarch64-linux support to resilio-sync pkgs #103357

merged 1 commit into from Nov 25, 2020

Conversation

rhoriguchi
Copy link
Contributor

@rhoriguchi rhoriguchi commented Nov 10, 2020 •
edited

Motivation for this change

I want to support arm64 so that I can run resilio-sync on a Raspberry Pi.

Official documentation states that aarch64-linux is supported.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS Raspberry Pi
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

@ofborg build resilio-sync

jonringer
jonringer reviewed Nov 24, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To comply with CONTRIBUTING.md please have the commit message name be of the format

<pkg-name>: <subject-line>

for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

in your case, the commit message should be:

resilio-sync: add aarch64 support

IvarWithoutBones
IvarWithoutBones approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine on my aarch64 machine.

@rhoriguchi
Copy link
Contributor Author

To comply with CONTRIBUTING.md please have the commit message name be of the format

<pkg-name>: <subject-line>

for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

in your case, the commit message should be:

resilio-sync: add aarch64 support

done

@ryantm ryantm merged commit 327338c into NixOS:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@IvarWithoutBones IvarWithoutBones IvarWithoutBones approved these changes

@domenkozar domenkozar Awaiting requested review from domenkozar

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@cwoac cwoac Awaiting requested review from cwoac

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rhoriguchi @jonringer @IvarWithoutBones @ryantm @Janik-Haag