Skip to content

ruby-modules gem-config: add exif #103337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ruby-modules gem-config: add exif #103337

wants to merge 1 commit into from
+4 −0

Conversation

maksar
Copy link
Contributor

@maksar maksar commented Nov 10, 2020 •
edited
Loading

Motivation for this change

Adding exif library to the gem-config.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@maksar maksar requested a review from alyssais as a code owner November 10, 2020 19:47
@ofborg ofborg bot added the 6.topic: ruby label Nov 10, 2020
@maksar maksar closed this Nov 10, 2020
@maksar
Copy link
Contributor Author

maksar commented Nov 10, 2020

forgot to add libexif to the params. will create a new pr

@SuperSandro2000
Copy link
Member

You can force push PRs and don't need to create new ones.

@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais

Assignees
No one assigned
Labels
6.topic: ruby 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maksar @SuperSandro2000 @Janik-Haag