chars: init at 0.5.0 #103363
Merged
chars: init at 0.5.0 #103363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvarWithoutBones
requested changes
Nov 11, 2020
|
uh. TIL. Thanks and done! |
IvarWithoutBones
approved these changes
Nov 11, 2020
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Co-authored-by: Ivar <41924494+IvarWithoutBones@users.noreply.github.com> Co-authored-by: Sandro Jäckel <sandro.jaeckel@gmail.com>
diff --git a/pkgs/tools/text/chars/default.nix b/pkgs/tools/text/chars/default.nix
index 18b29066ac56..fa58d110550e 100644
--- a/pkgs/tools/text/chars/default.nix
+++ b/pkgs/tools/text/chars/default.nix
@@ -1,6 +1,7 @@
-{ lib
+{ stdenv
, fetchFromGitHub
, rustPlatform
+, Security
}:
rustPlatform.buildRustPackage rec {
@@ -16,7 +17,9 @@ rustPlatform.buildRustPackage rec {
cargoSha256 = "1ampmw0l2wk2xp4q13aj5shxncqfh4dc3rsmpk2scaivanrsikn5";
- meta = with lib; {
+ buildInputs = stdenv.lib.optionals stdenv.isDarwin [ Security ];
+
+ meta = with stdenv.lib; {
description = "Commandline tool to display information about unicode characters";
homepage = "https://github.com/antifuchs/chars";
license = licenses.mit;
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index 7a00e1ec5bf4..6d58e2a81455 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -961,7 +961,9 @@ in
charm = callPackage ../applications/misc/charm { };
- chars = callPackage ../tools/text/chars { };
+ chars = callPackage ../tools/text/chars {
+ inherit (darwin.apple_sdk.frameworks) Security;
+ };
ec2_api_tools = callPackage ../tools/virtualization/ec2-api-tools { };
Fixes building on darwin. |
|
Result of 1 package built:
|
|
Thanks @SuperSandro2000 ! |
|
Result of 1 package built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)