gimpPlugins: replace references to registry.gimp.org #103348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jtojnar
reviewed
Nov 10, 2020
| @@ -196,18 +196,18 @@ stdenv.lib.makeScope pkgs.newScope (self: with self; { | |||
| lightning = scriptDerivation { | |||
| name = "Lightning"; | |||
| src = fetchurl { | |||
| url = "http://registry.gimp.org/files/Lightning.scm"; | |||
| url = "https://github.com/pixlsus/registry.gimp.org_static/raw/master/registry.gimp.org/files/files/Lightning.scm"; | |||
| sha256 = "c14a8f4f709695ede3f77348728a25b3f3ded420da60f3f8de3944b7eae98a49"; | |||
| }; | |||
| }; | |||
|
|
|||
| /* space in name trouble ? | |||
|
|
|||
| rainbowPlasma = scriptDerivation { | |||
There was a problem hiding this comment.
Probably time to drop these here as well.
There was a problem hiding this comment.
I removed rainbowPlasma and lightningGate but would rather not go too far into cleaning up gimpPlugins. I'm currently only interested in maintaining glimpsePlugins, sorry.
https://registry.gimp.org/ currently directs to a post [0] pronouncing it dead. A readonly mirror is available at [1]. Also bumped: - lqrPlugin: 0.6.1 -> 0.7.1 - removed rainbowPlasma, lightningGate as they were commented anyway. [0] https://www.gimp.org/registry/ [1] https://github.com/pixlsus/registry.gimp.org_static
erictapen
force-pushed
the
gimp-registry
branch
from
b953928
to
5a8b6e4
Compare
|
Mh yeah that would work probably. I just went through every hash and invalidated it, so now we know that nothing changed besides |
|
Thanks looks good. |
|
Follow-up in #103361. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://registry.gimp.org/ currently directs to a post [0] pronouncing
it dead. A readonly mirror is available at [1].
[0] https://www.gimp.org/registry/
[1] https://github.com/pixlsus/registry.gimp.org_static
This should be a noop. I tested it by building
gimp-with-plugins, without having it in my store before.Any ideas how to verify that FOD output didn't change without altering every single hash?
Pinging maintainer @jtojnar
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)