-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gimpPlugins: replace references to registry.gimp.org #103348
Conversation
|
@@ -196,18 +196,18 @@ stdenv.lib.makeScope pkgs.newScope (self: with self; { | |||
lightning = scriptDerivation { | |||
name = "Lightning"; | |||
src = fetchurl { | |||
url = "http://registry.gimp.org/files/Lightning.scm"; | |||
url = "https://github.com/pixlsus/registry.gimp.org_static/raw/master/registry.gimp.org/files/files/Lightning.scm"; | |||
sha256 = "c14a8f4f709695ede3f77348728a25b3f3ded420da60f3f8de3944b7eae98a49"; | |||
}; | |||
}; | |||
|
|||
/* space in name trouble ? | |||
|
|||
rainbowPlasma = scriptDerivation { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably time to drop these here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed rainbowPlasma and lightningGate but would rather not go too far into cleaning up gimpPlugins. I'm currently only interested in maintaining glimpsePlugins, sorry.
https://registry.gimp.org/ currently directs to a post [0] pronouncing it dead. A readonly mirror is available at [1]. Also bumped: - lqrPlugin: 0.6.1 -> 0.7.1 - removed rainbowPlasma, lightningGate as they were commented anyway. [0] https://www.gimp.org/registry/ [1] https://github.com/pixlsus/registry.gimp.org_static
b953928
to
5a8b6e4
Compare
Mh yeah that would work probably. I just went through every hash and invalidated it, so now we know that nothing changed besides |
Thanks looks good. |
Follow-up in #103361. |
https://registry.gimp.org/ currently directs to a post [0] pronouncing
it dead. A readonly mirror is available at [1].
[0] https://www.gimp.org/registry/
[1] https://github.com/pixlsus/registry.gimp.org_static
This should be a noop. I tested it by building
gimp-with-plugins
, without having it in my store before.Any ideas how to verify that FOD output didn't change without altering every single hash?
Pinging maintainer @jtojnar
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)