Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby-modules gem-config: add exif #103349

Merged
merged 2 commits into from Jul 14, 2021
Merged

ruby-modules gem-config: add exif #103349

merged 2 commits into from Jul 14, 2021

Conversation

maksar
Copy link
Contributor

@maksar maksar commented Nov 10, 2020 •
edited

Motivation for this change

Adding gem-config for the exif gem, which needs libexif in order to be biult.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Jan 10, 2021
View reviewed changes
pkgs/development/ruby-modules/gem-config/default.nix
@@ -179,6 +179,10 @@ in
buildInputs = [ openssl ];
};

exif = attrs: {
buildFlags = [ "--with-exif-dir=${libexif}" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this require libexif in buildInputs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are absolutely correct. I wasn't too familiar with nixpkgs at a time of pull request creation. It is fixed now, many thanks.

@stale
Copy link

stale bot commented Jul 11, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 11, 2021
@maksar maksar requested a review from marsam as a code owner July 12, 2021 09:50
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 12, 2021
marsam
marsam approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! sorry for the delay

@marsam marsam merged commit 1ee2dd6 into NixOS:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@marsam marsam marsam approved these changes

@alyssais alyssais Awaiting requested review from alyssais

Assignees
No one assigned
Labels
6.topic: ruby 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maksar @marsam @SuperSandro2000