Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset plugin XML id to commit 6581d478e3c #20

Merged
merged 2 commits into from Nov 12, 2020

Conversation

JojOatXGME
Copy link
Contributor

@JojOatXGME JojOatXGME commented Nov 10, 2020

Change the plugin XML ID back to the same ID used for previous releases on the Marketplace. This change actually affacts the plugin and should probably be released as a new version.

EDIT: If you want to release a new version, you have to wait until job Prepare Release / Update drafts for a GitHub release on the master branch has succeeded. You should then find a release draft on GitHub ready to be released.

EDIT: The ID has been changed from nix-idea to org.nixos.idea in 6581d47...ea2c5c8. You can inspect the ID of earlier releases at https://plugins.jetbrains.com/plugin/8607-nixidea/versions/stable/41592.

@JojOatXGME
Copy link
Contributor Author

An alternative aproach would be to keep the new ID and create a separate page on JetBrains Marketplace for all versions after 0.3.0.0.

@JojOatXGME
Copy link
Contributor Author

I just revised the wording in the changelog.

@JojOatXGME
Copy link
Contributor Author

@Mic92 Do you have any thoughts on this? I think this pull request should fix the issue which prevents us from publishing the plugin to JetBrains Marketplace.

If you want to test the publication before releasing the next version on GitHub, you could manually trigger the publication workflow before creating the release. If the publication works, you should not forget to also release the version on GitHub to keep both platforms in sync. Note that releasing the version on GitHub will trigger another run of the publication workflow. This last run will fail because you already published the version before creating the release, but that is fine. I hope this helps.

@Mic92 Mic92 merged commit ca3dd6c into NixOS:master Nov 12, 2020
@Mic92
Copy link
Member

Mic92 commented Nov 12, 2020

Let's just make a new release. No one cares if 3.0.0 is on the market place or not.

@Mic92
Copy link
Member

Mic92 commented Nov 12, 2020

Thanks for all the efforts. It seemed to work out in the end: https://github.com/NixOS/nix-idea/runs/1388975431?check_suite_focus=true

@JojOatXGME JojOatXGME deleted the fix_plugin_xml_id branch December 21, 2020 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants