firefox: fix aarch64 build #105437
Merged
firefox: fix aarch64 build #105437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch has been used on all our flavors for some time now. We can just move it to the common expression.
This patch fixes compilation on aarch64 that broke somewhere between the upgrade to the lateste rustc and the firefox 82 to 83 upgrade. The patch has been submitted upstream and can probably be removed on the next version bump.
These haven't been used in some time and there is no point in keeping them around. They just clutter the file right now.
lovesegfault
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I wanted to run Firefox on my RockPi4 so I digged into the current build error.
cc @samueldr since he is one of our "high profile" aarch64 users.
Things done
sandboxinnix.confon non-NixOS linux)