Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcomix3: manpage location, app icon #105450

Merged
merged 2 commits into from Dec 11, 2020
Merged

mcomix3: manpage location, app icon #105450

merged 2 commits into from Dec 11, 2020

Conversation

con-f-use
Copy link
Contributor

@con-f-use con-f-use commented Nov 30, 2020 •
edited

Motivation for this change

Application icon is currently missing in mcomix3. Additionally, man mcomix3 is failing, because the corresponding manpage is named mcomix instead of mcomix3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 30, 2020 •
edited

Result of nixpkgs-review pr 105450 1 on darwin

1 package built:
  • mcomix3

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105450 run on x86_64-linux 1

1 package built:
  • mcomix3

@con-f-use
Copy link
Contributor Author

@SuperSandro2000 can we get this merged now?

@con-f-use @SuperSandro2000
Update pkgs/applications/graphics/mcomix3/default.nix
aee5525 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@SuperSandro2000 SuperSandro2000 merged commit 5c0b0f3 into NixOS:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@con-f-use @SuperSandro2000