Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ibus-engines.rime: init at 1.4.0 #105449

Closed
wants to merge 1 commit into from
Closed

ibus-engines.rime: init at 1.4.0 #105449

wants to merge 1 commit into from

Conversation

mschuwalow
Copy link
Contributor

Motivation for this change

Adds an additional ibus engine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Nov 30, 2020
View reviewed changes
pkgs/top-level/all-packages.nix
@@ -3033,6 +3033,8 @@ in
protobuf = pkgs.protobuf3_8.overrideDerivation (oldAttrs: { stdenv = clangStdenv; });
};

rime = callPackage ../tools/inputmethods/ibus-engines/ibus-rime { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be put into ibus-engines = recurseIntoAttrs {. @jtojnar

pkgs/tools/inputmethods/ibus-engines/ibus-rime/default.nix Outdated Show resolved Hide resolved
pkgs/tools/inputmethods/ibus-engines/ibus-rime/default.nix Outdated Show resolved Hide resolved
pkgs/tools/inputmethods/ibus-engines/ibus-rime/default.nix Outdated Show resolved Hide resolved
pkgs/tools/inputmethods/ibus-engines/ibus-rime/default.nix Outdated Show resolved Hide resolved
pkgs/tools/inputmethods/ibus-engines/ibus-rime/default.nix Outdated Show resolved Hide resolved
@mschuwalow
Copy link
Contributor Author

Thanks @SuperSandro2000! Applied your formatting suggestions. I normally just use nixfmt to format my nix code. Do we have something similar we use at nixpkgs?

@SuperSandro2000
Copy link
Member

Thanks @SuperSandro2000! Applied your formatting suggestions. I normally just use nixfmt to format my nix code. Do we have something similar we use at nixpkgs?

I normally use https://github.com/nix-community/nixpkgs-fmt but it puts ever input on one line or one in each line which does not scale well with big packages.

SuperSandro2000
SuperSandro2000 reviewed Nov 30, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits together.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105449 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
1 package built:
  • ibus-engines.rime

@jtojnar
Copy link
Contributor

jtojnar commented Dec 1, 2020

Duplicate of #87735.

@mschuwalow
Copy link
Contributor Author

mschuwalow commented Dec 1, 2020 •
edited

Ahh, didn't see that one. Feel free to close this in favor of the other

@SuperSandro2000
Copy link
Member

Closing in favor of #87735

@mschuwalow mschuwalow deleted the ibus-rime branch December 1, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mschuwalow @SuperSandro2000 @jtojnar