Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruffle: init at nightly-2020-11-30 #105433

Merged
merged 1 commit into from Dec 2, 2020
Merged

Conversation

GovanifY
Copy link
Member

@GovanifY GovanifY commented Nov 30, 2020

Motivation for this change

Initial addition of ruffle, the flash player emulator. While it isn't feature complete in the future this could lead to a drop-in replacement for flashplayer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@RaghavSood
Copy link
Member

Result of nixpkgs-review pr 105433 run on x86_64-linux 1

1 package built:
  • ruffle

@RaghavSood
Copy link
Member

Builds and prints the help listing fine, but I can't actually test it since my hardware doesn't meet its definition of hardware acceleration friendly, for some reason.

pkgs/misc/emulators/ruffle/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/ruffle/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Does not build on darwin:

error: Package ‘alsa-lib-1.2.3’ in /Users/user/.cache/nixpkgs-review/pr-105433/nixpkgs/pkgs/os-specific/linux/alsa-lib/default.nix:31 is not supported on ‘x86_64-darwin’, refusing to evaluate.

@GovanifY
Copy link
Member Author

@SuperSandro2000 Fixed your comments. I don't have any Darwin machines available on my end, is there any easy way to test?

@vojta001
Copy link
Contributor

Exactly the same results as @RaghavSood

The package builds just fine, but any attempt to run an swf file produces

Fatal error:
Ruffle requires hardware acceleration, but no compatible graphics device was found supporting Vulkan, DirectX 12, Metal or Web GPU

I don't know whether it is my machine causing problems, or the derivation being incorrect. I have an nvidia GPU, if that helps with investigation.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 Fixed your comments. I don't have any Darwin machines available on my end, is there any easy way to test?

I normally would fix such packages but alsalib is not available on darwin. If upstream does not support it either change platforms to linux only, otherwise mark it broken on darwin for now.

@GovanifY
Copy link
Member Author

GovanifY commented Dec 2, 2020

@SuperSandro2000 Fixed your comments. I don't have any Darwin machines available on my end, is there any easy way to test?

I normally would fix such packages but alsalib is not available on darwin. If upstream does not support it either change platforms to linux only, otherwise mark it broken on darwin for now.

Switched to linux only for now.

Exactly the same results as @RaghavSood

The package builds just fine, but any attempt to run an swf file produces

Fatal error:
Ruffle requires hardware acceleration, but no compatible graphics device was found supporting Vulkan, DirectX 12, Metal or Web GPU

I don't know whether it is my machine causing problems, or the derivation being incorrect. I have an nvidia GPU, if that helps with investigation.

Also doesn't run on AMD, for some reason wgpu doesn't detect any hw accel, not sure why.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105433 run on x86_64-linux 1

1 package built:
  • ruffle

@SuperSandro2000 SuperSandro2000 merged commit b0a0f71 into NixOS:master Dec 2, 2020
@ghost
Copy link

ghost commented Jan 10, 2021

Setting LD_LIBRARY_PATH to ${vulkan-loader}/lib at runtime solves this error, see gfx-rs/wgpu-rs#332.
A patchelf --set-rpath in postFixup should work as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants