deno: 1.5.3 -> 1.5.4 -> 1.6.0 -> 1.6.1 -> 1.6.2 -> 1.6.3 #104674

06kellyjac · 2020-11-23T15:43:49Z

Motivation for this change

Bump deno to ~~1.5.4~~ ~~1.6.0~~ ~~1.6.1~~ ~~1.6.2~~ 1.6.3

Big change in 1.6.0: can now use deno to compile/bundle a binary

It bundles and runs successfully on nix. Since it's using the underlying deno binary it's linked to all the same dependencies and will only work on a nix machine with said pinned dependencies.
I think that's fine for now, this is an early implementation of the feature.

I haven't seen much on a static version. I'm guessing in theory a static rust binary could be created with the 86_64-unknown-linux-musl toolchain but there isn't a pre-compiled rusty_v8 library for it and that'll take ages for us to compile so I'm not planning on trying that until there's a pre-compiled lib file.

$ ./result/bin/deno compile --unstable https://deno.land/std@0.79.0/examples/cat.ts
Download https://deno.land/std@0.79.0/examples/cat.ts
Check https://deno.land/std@0.79.0/examples/cat.ts
Bundle https://deno.land/std@0.79.0/examples/cat.ts
Compile https://deno.land/std@0.79.0/examples/cat.ts
Emit cat

$ ./cat README.md
<p align="center">
  <a href="https://nixos.org/nixos"><img src="https://nixos.org/logo/nixos-hires.png" width="500px" alt="NixOS logo" /></a>
</p>
# ...

$ ldd cat
	linux-vdso.so.1 (0x00007ffce21ec000)
	libgcc_s.so.1 => /nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/libgcc_s.so.1 (0x00007f0a7f613000)
	libc.so.6 => /nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/libc.so.6 (0x00007f0a7f452000)
	/nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/ld-linux-x86-64.so.2 => /nix/store/a3syww9igm49zdzq3ibzw9m8ccvsgxla-glibc-2.32/lib64/ld-linux-x86-64.so.2 (0x00007f0a817b8000)
	libm.so.6 => /nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/libm.so.6 (0x00007f0a7f30f000)
	libpthread.so.0 => /nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/libpthread.so.0 (0x00007f0a7f2ee000)
	libdl.so.2 => /nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/libdl.so.2 (0x00007f0a7f2e9000)

ldd ./result/bin/deno
	linux-vdso.so.1 (0x00007ffc60d80000)
	libgcc_s.so.1 => /nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/libgcc_s.so.1 (0x00007fa711ede000)
	libc.so.6 => /nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/libc.so.6 (0x00007fa711d1d000)
	/nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/ld-linux-x86-64.so.2 => /nix/store/a3syww9igm49zdzq3ibzw9m8ccvsgxla-glibc-2.32/lib64/ld-linux-x86-64.so.2 (0x00007fa714083000)
	libm.so.6 => /nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/libm.so.6 (0x00007fa711bda000)
	libpthread.so.0 => /nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/libpthread.so.0 (0x00007fa711bb9000)
	libdl.so.2 => /nix/store/9l06v7fc38c1x3r2iydl15ksgz0ysb82-glibc-2.32/lib/libdl.so.2 (0x00007fa711bb4000)

~~had to remove ZSH completion in 1.5.4 until it's fixed~~ fixed in 1.6.1

    Finished release [optimized] target(s) in 12m 14s
installing
thread 'main' panicked at 'Fatal internal error. Please consider filing a bug report at https://github.com/clap-rs/clap/issues', /build/deno-1.5.4-vendor.tar.gz/clap/src/completions/zsh.rs:407:29
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5cpmhqpfz2mql2jmmmyjnj1piiilknmj-deno-1.5.4
# ... etc

Things done

06kellyjac · 2020-12-01T15:01:16Z

I've removed zsh completion until it's fixed and un-drafting as it's probably going to be a while until the zsh completion is finished

06kellyjac · 2020-12-01T15:05:22Z

Result of nixpkgs-review pr 104674 run on x86_64-linux 1

1 package built:

deno

priegger · 2020-12-11T09:56:29Z

Deno 1.6.0 is out: https://github.com/denoland/deno/releases/tag/v1.6.0

06kellyjac · 2020-12-11T10:24:28Z

Ah I thought I'd updated this pr already. On it
Will be interesting to see if deno compile will need any wangjangling to make it work

06kellyjac · 2020-12-11T10:56:46Z

Result of nixpkgs-review pr 104674 run on x86_64-linux 1

1 package built:

deno

06kellyjac · 2020-12-16T09:52:03Z

/marvin opt-in
/status needs_reviewer

marvin-mk2 · 2020-12-16T09:52:05Z

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

priegger

Version 1.6.1 compiles for me, I tested it using:

https://deno.land/std@0.79.0/examples/cat.ts

And the resulting cat binary behaves like cat, so looks good to me! Thanks!

pkgs/development/web/deno/default.nix

marvin-mk2 · 2020-12-19T18:16:35Z

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

06kellyjac · 2020-12-22T18:08:04Z

This PR is now almost 1 month old 🍰

06kellyjac · 2020-12-22T18:10:08Z

Result of nixpkgs-review pr 104674 run on x86_64-linux 1

1 package built:

deno

marvin-mk2 · 2020-12-25T23:19:28Z

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

marvin-mk2 · 2020-12-29T01:59:36Z

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR ~~will be~~ should be put back in the needs_reviewer queue in one day.

Note: This feature is currently broken. The bot will not actually change the status. If you see this message multiple times, please request a status change manually.

priegger · 2020-12-29T12:36:54Z

Result of nixpkgs-review pr 104674 run on x86_64-linux 1

1 package built:

deno

priegger

Only checked x86_64 and only tested the deno hello world (deno run https://deno.land/std/examples/welcome.ts).

marvin-mk2 · 2021-01-01T14:32:54Z

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR ~~will be~~ should be put back in the needs_reviewer queue in one day.

Note: This feature is currently broken. The bot will not actually change the status. If you see this message multiple times, please request a status change manually.

06kellyjac · 2021-01-01T15:04:38Z

/status needs_reviewer

06kellyjac · 2021-01-01T15:05:11Z

Result of nixpkgs-review pr 104674 run on x86_64-linux 1

1 package built:

deno

Ekleog · 2021-01-02T15:47:15Z

LGTM, thank you! Let's just check the darwin build before landing.

@ofborg build deno

Ekleog · 2021-01-03T11:21:23Z

Actually turns out darwin builders are currently dead, I was thinking this had been fixed but it turns out not. So let's land, thank you! :)

06kellyjac mentioned this pull request Nov 23, 2020

zsh completion fails for 1.5.4 denoland/deno#8472

Closed

06kellyjac force-pushed the deno branch from 9ac2d02 to 48bdc14 Compare December 1, 2020 15:00

06kellyjac marked this pull request as ready for review December 1, 2020 15:01

ofborg bot added 11.by: package-maintainer 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Dec 1, 2020

06kellyjac changed the title ~~deno: 1.5.3 -> 1.5.4~~ deno: 1.5.3 -> 1.5.4 -> 1.6.0 Dec 11, 2020

06kellyjac force-pushed the deno branch from 48bdc14 to 822d134 Compare December 11, 2020 10:54

06kellyjac force-pushed the deno branch from 822d134 to e1a6935 Compare December 15, 2020 11:22

marvin-mk2 bot added marvin needs_reviewer awaiting_reviewer and removed needs_reviewer labels Dec 16, 2020

priegger reviewed Dec 16, 2020

View reviewed changes

pkgs/development/web/deno/default.nix Outdated Show resolved Hide resolved

06kellyjac force-pushed the deno branch from e1a6935 to d4fee6b Compare December 16, 2020 11:00

06kellyjac changed the title ~~deno: 1.5.3 -> 1.5.4 -> 1.6.0~~ deno: 1.5.3 -> 1.5.4 -> 1.6.0 -> 1.6.1 Dec 16, 2020

06kellyjac force-pushed the deno branch from d4fee6b to 003fd85 Compare December 22, 2020 18:04

06kellyjac changed the title ~~deno: 1.5.3 -> 1.5.4 -> 1.6.0 -> 1.6.1~~ deno: 1.5.3 -> 1.5.4 -> 1.6.0 -> 1.6.1 -> 1.6.2 Dec 22, 2020

priegger approved these changes Dec 29, 2020

View reviewed changes

06kellyjac added 4 commits January 1, 2021 10:41

deno: 1.5.3 -> 1.5.4

68e0f80

deno: 1.5.4 -> 1.6.0

3db6bba

deno: 1.6.0 -> 1.6.1

ba9896e

deno: 1.6.1 -> 1.6.2

41b9393

deno: 1.6.2 -> 1.6.3

40ce61a

06kellyjac force-pushed the deno branch from 003fd85 to 40ce61a Compare January 1, 2021 15:01

06kellyjac changed the title ~~deno: 1.5.3 -> 1.5.4 -> 1.6.0 -> 1.6.1 -> 1.6.2~~ deno: 1.5.3 -> 1.5.4 -> 1.6.0 -> 1.6.1 -> 1.6.2 -> 1.6.3 Jan 1, 2021

marvin-mk2 bot added needs_reviewer and removed awaiting_reviewer labels Jan 1, 2021

marvin-mk2 bot requested a review from Ekleog January 1, 2021 15:05

marvin-mk2 bot added awaiting_reviewer and removed needs_reviewer labels Jan 1, 2021

Ekleog approved these changes Jan 2, 2021

View reviewed changes

Ekleog merged commit 2847e38 into NixOS:master Jan 3, 2021

06kellyjac deleted the deno branch January 3, 2021 11:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deno: 1.5.3 -> 1.5.4 -> 1.6.0 -> 1.6.1 -> 1.6.2 -> 1.6.3 #104674

deno: 1.5.3 -> 1.5.4 -> 1.6.0 -> 1.6.1 -> 1.6.2 -> 1.6.3 #104674

06kellyjac commented Nov 23, 2020 •

edited

06kellyjac commented Dec 1, 2020

06kellyjac commented Dec 1, 2020

priegger commented Dec 11, 2020

06kellyjac commented Dec 11, 2020 •

edited

06kellyjac commented Dec 11, 2020

06kellyjac commented Dec 16, 2020

marvin-mk2 bot commented Dec 16, 2020

priegger left a comment

marvin-mk2 bot commented Dec 19, 2020

06kellyjac commented Dec 22, 2020

06kellyjac commented Dec 22, 2020

marvin-mk2 bot commented Dec 25, 2020

marvin-mk2 bot commented Dec 29, 2020

priegger commented Dec 29, 2020

priegger left a comment

marvin-mk2 bot commented Jan 1, 2021

06kellyjac commented Jan 1, 2021

06kellyjac commented Jan 1, 2021

Ekleog commented Jan 2, 2021

Ekleog commented Jan 3, 2021

Navigation Menu

deno: 1.5.3 -> 1.5.4 -> 1.6.0 -> 1.6.1 -> 1.6.2 -> 1.6.3 #104674

deno: 1.5.3 -> 1.5.4 -> 1.6.0 -> 1.6.1 -> 1.6.2 -> 1.6.3 #104674

Conversation

06kellyjac commented Nov 23, 2020 • edited

Motivation for this change

Things done

06kellyjac commented Dec 1, 2020

06kellyjac commented Dec 1, 2020

priegger commented Dec 11, 2020

06kellyjac commented Dec 11, 2020 • edited

06kellyjac commented Dec 11, 2020

06kellyjac commented Dec 16, 2020

marvin-mk2 bot commented Dec 16, 2020

priegger left a comment

Choose a reason for hiding this comment

marvin-mk2 bot commented Dec 19, 2020

06kellyjac commented Dec 22, 2020

06kellyjac commented Dec 22, 2020

marvin-mk2 bot commented Dec 25, 2020

marvin-mk2 bot commented Dec 29, 2020

priegger commented Dec 29, 2020

priegger left a comment

Choose a reason for hiding this comment

marvin-mk2 bot commented Jan 1, 2021

06kellyjac commented Jan 1, 2021

06kellyjac commented Jan 1, 2021

Ekleog commented Jan 2, 2021

Ekleog commented Jan 3, 2021

06kellyjac commented Nov 23, 2020 •

edited

06kellyjac commented Dec 11, 2020 •

edited