New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.kivy: init at 2.0.0 #104694
Conversation
I chose to directly package Kivy 2.0.0rc4 because it supports cython 0.29.21, which is the version in nixpkgs. |
For Kivy itself I think you're likely to also need pkg-config:
(I think you want pkg-config, not pkgconfig in nativeBuildInputs?) |
Yes indeed, it's weird it was building on my machine with |
pkgconfig is an alias of pkg-config and the later is preferred. |
I think one of the reasons for that is there's a separate Python module called "pkgconfig" which, err, does something different (so in the python-modules directory you end up with that instead, which doesn't work) |
Result of 3 packages built:
|
I'm no longer actively using Kivy so I'm passing on this one... good luck
though!
…On Mon, Nov 23, 2020 at 7:54 PM Luke Granger-Brown ***@***.***> wrote:
I think you want pkg-config, not pkgconfig in nativeBuildInputs?)
pkgconfig is an alias of pkg-config and the later is preferred.
I think one of the reasons for that is there's a separate Python module
called "pkgconfig" which, err, does something different (so in the
python-modules directory you end up with that instead, which doesn't work)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#104694 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABWUWKCLCDKJMFANP5UQE3SRKVSHANCNFSM4T72HP3Q>
.[image: Web Bug from
https://github.com/notifications/beacon/AABWUWIYSIDC7WIL5XF6FUTSRKVSHA5CNFSM4T72HP32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFOTOGFY.gif]
[ { ***@***.***": "http://schema.org", ***@***.***": "EmailMessage",
"potentialAction": { ***@***.***": "ViewAction", "target": "
#104694 (comment)",
"url": "
#104694 (comment)",
"name": "View Pull Request" }, "description": "View this Pull Request on
GitHub", "publisher": { ***@***.***": "Organization", "name": "GitHub", "url": "
https://github.com" } } ]
--
Klaas van Schelven
+31 6 811 599 10
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you may have to do some heavy patching for kivy to work well with nix (as in, patch all the locations, and potentially have to regenerate that patch every package update) as normal dll calls will not work.
950ae74
to
d1e9a99
Compare
As far as I tested with a friend's project using this, it seems to work. It probably doesn't use all of Kivy's features though, so some stuff might be broken, but we can always open fixup PRs later on as we discover features that do not work. |
b8948e8
to
a537cf0
Compare
I think this is now ready. |
Result of 6 packages built:
kivy-garden
Please fix that no tests are run or disable them and add a pythonImportCheck. |
Done! |
Result of 6 packages built:
|
What is remaining on this PR prior to merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ofborg eval
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 6 packages built:
The following issues got detected with the above build packages. python37Packages.kivy-garden: Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
A typo in pythonImportsCheck got detected. Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
A typo in pythonImportsCheck got detected. Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
A typo in pythonImportsCheck got detected. |
91dc52b
to
e6de987
Compare
I fixed the typo in |
Result of 6 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still the zero tests run by kiva-garden. After that this should be good to go.
The |
fine for me. Then just add |
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
Done! |
Thank you for taking the time to package this! I'll be using it later. |
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 6 packages built:
The following issues got detected with the above build packages.
python37Packages.kivy:
Unused argument:
Unused argument:
Unused argument:
Unused argument:
Unused argument:
Unused argument:
|
Signed-off-by: Marc 'risson' Schmitt <marc.schmitt@risson.space>
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 3 packages marked as broken and skipped:
3 packages built:
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 6 packages built:
|
Motivation for this change
Building on top of #29305, and finally having Kivy in nixpkgs!
I actually don't know how to test this work so I'm asking @vanschelven and @ddorn to help me out.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)