Remove annotated-spec-related functionality from canvas tests #26619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functionality to generate an annotated canvas spec was removed in commit dadd085, but remnants of it have been lingering in the codebase, confusing anyone who tries to make sense of the canvas tests. This removes those remnants.
This was used for disambiguation when generating an annotated spec that is no longer generated.
This is where links to the generated tests would be inserted in the annotated spec, which is no longer generated.
wpt-pr-bot
requested review from
AmeliaBR,
annevk,
domenic,
foolip,
fserb,
jdm,
jgraham,
kenrussell and
zqzhang
fserb
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the cruft I mentioned in #26618.
I've split this into three commits:
current-work-canvas.xhtmland related Python script functionality.previouslyfield fromspec.yaml.<^>and<eol>syntax from the text snippets inspec.yaml. It appears that<^>was used to indicate where links to relevant tests would be inserted into the text, and<eol>was used to aid text processing. I've kept<...>as I believe it has relevant semantic meaning but I'd be open to removing it as well.