Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elmPackages: add elm-graphql and elm-review #104709

Closed
wants to merge 1 commit into from

Conversation

jaredramirez
Copy link
Contributor

@jaredramirez jaredramirez commented Nov 23, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Pinging @jonringer since he reviewed my last PR related to Elm!

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix elm-review

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/jon/.cache/nixpkgs-review/pr-104709/build.nix
builder for '/nix/store/i332wx2jskb78m01g9k8lrj8ykd8fyrw-node_elm-review-2.3.3.drv' failed with exit code 1; last 10 log lines:
  npm WARN optional SKIPPING OPTIONAL DEPENDENCY: xo@^0.33.0 (node_modules/xo):
  npm WARN optional SKIPPING OPTIONAL DEPENDENCY: request to https://registry.npmjs.org/xo failed: cache mode is 'only-if-cached' but no cached response available.

  up to date in 0.73s

  19 packages are looking for funding
    run `npm fund` for details

  linking elmi-to-json
  ln: failed to create symbolic link 'node_modules/elmi-to-json/bin/elmi-to-json': No such file or directory
cannot build derivation '/nix/store/p71p98n0qf5qszjmdfp286i3s1rfswp1-env.drv': 1 dependencies couldn't be built
[36 built (1 failed), 3 copied (294.7 MiB), 36.9 MiB DL]
error: build of '/nix/store/p71p98n0qf5qszjmdfp286i3s1rfswp1-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/104709
1 package failed to build:
elmPackages.elm-review

@SuperSandro2000
Copy link
Member

@jaredramirez ping

@jaredramirez
Copy link
Contributor Author

Hey, I don't need these packages anymore so I'll close this for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants