poetry2nix: cross fixes #104707
poetry2nix: cross fixes #104707
Conversation
When cross compiling setuptools isn't available in the build environment but needed for eg. python setup.py egg_info.
While building PYTHONPATH includes pythonForBuild which can only be used during the build. Just tracking propagated inputs here should be enough.
|
This should go to the If you make a PR against the proper upstream I'll make sure to get it merged and into nixpkgs quickly. |
| @@ -120,6 +120,8 @@ self: super: | |||
|
|
|||
| cryptography = super.cryptography.overridePythonAttrs ( | |||
| old: { | |||
| nativeBuildInputs = old.nativeBuildInputs or [] | |||
| ++ stdenv.lib.optional (stdenv.buildPlatform != stdenv.hostPlatform) self.python.pythonForBuild.pkgs.cffi; | |||
There was a problem hiding this comment.
this is fixed on staging-next, the whole nativeBuildInputs override can be removed
Wait, I need to check...
There was a problem hiding this comment.
I based this on staging since this depends on the recent fixes merged there, but these overrides are poetry specific the standard cryptography worked IIRC.
|
@adisbladis Oh I see, I'll relocate the pr. ps. Might be a good idea to add a header to these files, a bit more discoverable than a burried readme. |
Motivation for this change
Make poetry2nix builds work when cross compiling.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)