Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parts of canvas tests relating to generating an annotated spec should be removed #26618

Closed
adroitwhiz opened this issue Nov 23, 2020 · 0 comments
Closed

Parts of canvas tests relating to generating an annotated spec should be removed #26618

adroitwhiz opened this issue Nov 23, 2020 · 0 comments

Comments

@adroitwhiz
Copy link
Contributor

Previously, running the canvas tests' build.sh generated an annotated version of the HTML canvas spec.

This functionality has been removed in dadd085, but some cruft has been left behind:

  • html/canvas/tools/current-work-canvas.xhtml, which is a stripped-down version of the canvas spec previously used to generate the annotated version.
  • html/canvas/tools/specextract.py, which generates current-work-canvas.xhtml.
  • Weird syntax in html/canvas/tools/spec.yaml (e.g. <^>, <...>, <eol>), which, as far as I can tell, only exists to aid in the generation of the annotated spec.
  • The previously field, also in spec.yaml, which appears to be unused now.
  • The htmlSerializer and getNodeText functions in html/canvas/tools/gentestutils.py, which was used only to serialize the annotated spec.

These should be removed if possible--I'm trying to write tests for a proposal that modifies a substantial amount of the canvas spec, and having so many supporting changes in place for removed functionality led me down a rabbit hole of confusion.
@adroitwhiz adroitwhiz mentioned this issue Nov 23, 2020
Merged
Merged
chromium-wpt-export-bot pushed a commit that referenced this issue Oct 8, 2022
@graveljp @chromium-wpt-export-bot
Batch remove all 'testing:' spec references.
4a9b9e4 
These were references to an annotated spec, though that feature has
been partially remove already. The annotated spec was deleted in:
dadd085

There has been a previous effort for removing this code, but there
was some left-overs:
#26618

Bug: 1335173
Change-Id: I3ee669153abfd2e6996ce59616f0e9eb0b58f264
chromium-wpt-export-bot pushed a commit that referenced this issue Oct 14, 2022
@graveljp @chromium-wpt-export-bot
Batch remove all 'testing:' spec references.
97405f3 
These were references to annotated specs, though that feature has been
partially remove already. The annotated spec was deleted in:
dadd085

There has been a previous effort for removing this code, but there as
some left-overs:
#26618

Bug: 1335173
Change-Id: I3ee669153abfd2e6996ce59616f0e9eb0b58f264
chromium-wpt-export-bot pushed a commit that referenced this issue Oct 17, 2022
@graveljp @chromium-wpt-export-bot
Batch remove all 'testing:' spec references.
d92f353 
These were references to annotated specs, though that feature has been
partially remove already. The annotated spec was deleted in:
dadd085

There has been a previous effort for removing this code, but there as
some left-overs:
#26618

Bug: 1335173
Change-Id: I3ee669153abfd2e6996ce59616f0e9eb0b58f264
chromium-wpt-export-bot pushed a commit that referenced this issue Oct 19, 2022
@graveljp @chromium-wpt-export-bot
Batch remove all 'testing:' spec references.
f3d0d1f 
These were references to annotated specs, though that feature has been
partially remove already. The annotated spec was deleted in:
dadd085

There has been a previous effort for removing this code, but there as
some left-overs:
#26618

Bug: 1335173
Change-Id: I3ee669153abfd2e6996ce59616f0e9eb0b58f264
aarongable pushed a commit to chromium/chromium that referenced this issue Oct 19, 2022
@graveljp
Batch remove all 'testing:' spec references.
6794899 
These were references to annotated specs, though that feature has been
partially remove already. The annotated spec was deleted in:
web-platform-tests/wpt@dadd085

There has been a previous effort for removing this code, but there as
some left-overs:
web-platform-tests/wpt#26618

Bug: 1335173
Change-Id: I3ee669153abfd2e6996ce59616f0e9eb0b58f264
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3937132
Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1061133}
chromium-wpt-export-bot pushed a commit that referenced this issue Oct 19, 2022
@graveljp @chromium-wpt-export-bot
Batch remove all 'testing:' spec references.
e5e26a1 
These were references to annotated specs, though that feature has been
partially remove already. The annotated spec was deleted in:
dadd085

There has been a previous effort for removing this code, but there as
some left-overs:
#26618

Bug: 1335173
Change-Id: I3ee669153abfd2e6996ce59616f0e9eb0b58f264
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3937132
Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1061133}
chromium-wpt-export-bot pushed a commit that referenced this issue Oct 19, 2022
@graveljp @chromium-wpt-export-bot
Batch remove all 'testing:' spec references.
d1e7852 
These were references to annotated specs, though that feature has been
partially remove already. The annotated spec was deleted in:
dadd085

There has been a previous effort for removing this code, but there as
some left-overs:
#26618

Bug: 1335173
Change-Id: I3ee669153abfd2e6996ce59616f0e9eb0b58f264
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3937132
Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1061133}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Oct 26, 2022
@graveljp @moz-wptsync-bot
Bug 1794190 [wpt PR 36339] - Batch remove all 'testing:' spec referen…
027a1fa 
…ces., a=testonly

Automatic update from web-platform-tests
Batch remove all 'testing:' spec references.

These were references to annotated specs, though that feature has been
partially remove already. The annotated spec was deleted in:
web-platform-tests/wpt@dadd085

There has been a previous effort for removing this code, but there as
some left-overs:
web-platform-tests/wpt#26618

Bug: 1335173
Change-Id: I3ee669153abfd2e6996ce59616f0e9eb0b58f264
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3937132
Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1061133}

--

wpt-commits: d1e78524fc8991f8ec84aa99d25ec75055dfac92
wpt-pr: 36339
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Oct 31, 2022
@graveljp @moz-wptsync-bot
Bug 1794190 [wpt PR 36339] - Batch remove all 'testing:' spec referen…
afac7d8 
…ces., a=testonly

Automatic update from web-platform-tests
Batch remove all 'testing:' spec references.

These were references to annotated specs, though that feature has been
partially remove already. The annotated spec was deleted in:
web-platform-tests/wpt@dadd085

There has been a previous effort for removing this code, but there as
some left-overs:
web-platform-tests/wpt#26618

Bug: 1335173
Change-Id: I3ee669153abfd2e6996ce59616f0e9eb0b58f264
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3937132
Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1061133}

--

wpt-commits: d1e78524fc8991f8ec84aa99d25ec75055dfac92
wpt-pr: 36339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adroitwhiz