Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.mesa: unstable-2019-12-09 -> 0.8.7 #104672

Merged
merged 1 commit into from Nov 23, 2020
Merged

pythonPackages.mesa: unstable-2019-12-09 -> 0.8.7 #104672

merged 1 commit into from Nov 23, 2020

Conversation

dpaetzel
Copy link
Contributor

Motivation for this change

Using unstable (the version currently in nixpkgs) fixed some problems. By now, there exists a working stable (which fixes additional issues and, I think, stable releases are generally preferred(?)).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@RaghavSood
Copy link
Member

Result of nixpkgs-review pr 104672 1

2 packages built:
  • python37Packages.mesa
  • python38Packages.mesa

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

jonringer
jonringer approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/104672
2 packages built:
python37Packages.mesa python38Packages.mesa

@jonringer jonringer merged commit 2c72118 into NixOS:master Nov 23, 2020
@dpaetzel
Copy link
Contributor Author

Thank you! 🙂

@dpaetzel dpaetzel deleted the update-mesa branch November 24, 2020 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dpaetzel @RaghavSood @jonringer