Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freac: init 1.1.3 #104690

Merged
merged 3 commits into from Mar 6, 2021
Merged

freac: init 1.1.3 #104690

merged 3 commits into from Mar 6, 2021

Conversation

SCOTT-HAMILTON
Copy link
Contributor

@SCOTT-HAMILTON SCOTT-HAMILTON commented Nov 23, 2020 •
edited by veprbl

Motivation for this change

Closes: #104671

Things done

Packaged fre:ac at 1.1.3, and deps.
I don't know if this is my configuration but running freac (which I've never used) had some weird rendering issues

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Nov 23, 2020
View reviewed changes
pkgs/applications/audio/freac/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/boca/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/smooth/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/smooth/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104690 run on x86_64-linux 1

3 packages built:
  • boca
  • freac
  • smooth

@SCOTT-HAMILTON
Copy link
Contributor Author

Stupid me, I've almost lost the two first commits.

@davidak
Copy link
Member

davidak commented Mar 6, 2021

Result of nixpkgs-review pr 104690 run on x86_64-linux 1

3 packages built:
  • boca
  • freac
  • smooth

davidak
davidak approved these changes Mar 6, 2021
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM

Builds and works

Thanks @SCOTT-HAMILTON!

@davidak
Copy link
Member

davidak commented Mar 6, 2021

Screenshot from 2021-03-06 23-54-47

The white font on light grey is a very interesting design choice.

@davidak davidak merged commit aebd423 into NixOS:master Mar 6, 2021
@cirno-999
Copy link
Contributor

The white font on light grey is a very interesting design choice.

Maybe it's a theming issue that's possible to fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fre:ac packaging request
4 participants
@SCOTT-HAMILTON @SuperSandro2000 @davidak @cirno-999