[Python3] Make echo-content-escaped.py py3-compliant #26615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iterating over a 'bytes' object in Python gives ints, not bytes, and in Python 3 it is a type error to compare ints to bytes like this method does. Cast back to bytes to avoid the error.
wpt-pr-bot
requested review from
inexorabletash,
jdm,
mkruisselbrink and
zqzhang
Hexcles
approved these changes
Nov 23, 2020
Hexcles
added a commit
that referenced
this pull request
Nov 25, 2020
The fix in #26615 only works in Py3. This time we make it compatible with Py2 & Py3.
Hexcles
added a commit
that referenced
this pull request
Nov 25, 2020
The fix in #26615 only works in Py3. This time we make it compatible with Py2 & Py3.
Hexcles
added a commit
that referenced
this pull request
Nov 25, 2020
The fix in #26615 only works in Py3. This time we make it compatible with Py2 & Py3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterating over a 'bytes' object in Python gives ints, not bytes, and in
Python 3 it is a type error to compare ints to bytes like this method
does. Cast back to bytes to avoid the error.