[WebNFC] Remove unused CancelAllWatches #26616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 23, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2554575
branch
4 times, most recently
from
f1fa429
to
116040f
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2554575
branch
2 times, most recently
from
a957d32
to
586ca30
Compare
This CL removes the unused method CancelAllWatches() that used to cancel all watch NFC operations. It also removes one duplicated web platform test that was referencing obsolete NDEFScanOptions id. Change-Id: I1a702cae22b7525a9229da818bec91255a273f4b Bug: 520391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554575 Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#832300}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2554575
branch
from
586ca30
to
d92da12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL removes the unused method CancelAllWatches() that used to cancel
all watch NFC operations. It also removes one duplicated web platform
test that was referencing obsolete NDEFScanOptions id.
Change-Id: I1a702cae22b7525a9229da818bec91255a273f4b
Bug: 520391
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554575
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#832300}