Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kube3d: 3.2.1 -> 3.3.0 #104681

Merged
merged 1 commit into from Nov 24, 2020
Merged

kube3d: 3.2.1 -> 3.3.0 #104681

merged 1 commit into from Nov 24, 2020

Conversation

06kellyjac
Copy link
Member

@06kellyjac 06kellyjac commented Nov 23, 2020 •
edited

Motivation for this change

Bump kube3d/k3d to 3.3.0, also bumped k3sVersion to match the official release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (x86_64)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@06kellyjac
Copy link
Member Author

Result of nixpkgs-review pr 104681 1

1 package built:
  • kube3d

1 similar comment
@RaghavSood
Copy link
Member

Result of nixpkgs-review pr 104681 1

1 package built:
  • kube3d

@06kellyjac
Copy link
Member Author

that was fast @RaghavSood !

@RaghavSood
Copy link
Member

You managed to beat me by 13 seconds :)

LGTM

@06kellyjac
Copy link
Member Author

Well it is my own PR so I had a head start 😅

@06kellyjac
Copy link
Member Author

/marvin opt-in

If you'd like you can run /status needs_merger, PR creators can't run it themselves

@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 23, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the marvin label Nov 23, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 23, 2020

The PR author cannot set the status to needs_merger. Please wait for an external review.

If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104681 run on x86_64-darwin 1

@vikanezrimaya
Copy link
Member

/status needs_merger

@06kellyjac
Copy link
Member Author

Thanks @kisik21

@marvin-mk2 marvin-mk2 bot requested a review from kevincox November 24, 2020 21:37
@prusnak prusnak merged commit 0c6fc3c into NixOS:master Nov 24, 2020
@06kellyjac 06kellyjac deleted the kube3d branch November 24, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaghavSood RaghavSood RaghavSood approved these changes

@kevincox kevincox Awaiting requested review from kevincox

Assignees
No one assigned
Labels
awaiting_merger marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@06kellyjac @RaghavSood @SuperSandro2000 @vikanezrimaya @prusnak